-
Couldn't load subscription status.
- Fork 2k
fix: make doc previews theme aware #20647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make doc previews theme aware #20647
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20647 +/- ##
==========================================
+ Coverage 91.39% 92.11% +0.71%
==========================================
Files 485 492 +7
Lines 31370 34352 +2982
Branches 5430 5586 +156
==========================================
+ Hits 28670 31642 +2972
- Misses 2547 2563 +16
+ Partials 153 147 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
vrt shard 3/4 didn't complete can anyone restart it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! I restarted the vrt job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8f38d05
Closes #20645
THESE ARE STORYBOOK ONLY STYLE UPDATES
Adds background to docs previews of the components so they show properly on every theme in storybook. both react and web-components
Changelog
New
.docs-storyelement in both web components and reactTesting / Reviewing
change theme to any other variant (more noticeable in dark variants) in storybook and observe all the stories docs pages in both react and web components render with proper background in the preview
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)[ ] Tested for cross-browser consistencyMore details can be found in the pull request guide