Skip to content

Conversation

@devadula-nandan
Copy link
Contributor

@devadula-nandan devadula-nandan commented Oct 3, 2025

Closes #20645

THESE ARE STORYBOOK ONLY STYLE UPDATES

Adds background to docs previews of the components so they show properly on every theme in storybook. both react and web-components

Changelog

New

  • added theme background to .docs-story element in both web components and react

Testing / Reviewing

change theme to any other variant (more noticeable in dark variants) in storybook and observe all the stories docs pages in both react and web components render with proper background in the preview

Screenshot 2025-10-03 at 4 05 37 PM

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • [ ] Updated documentation and storybook examples
  • [ ] Wrote passing tests that cover this change
  • [ ] Addressed any impact on accessibility (a11y)
  • [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@devadula-nandan devadula-nandan marked this pull request as ready for review October 3, 2025 10:41
@devadula-nandan devadula-nandan requested a review from a team as a code owner October 3, 2025 10:41
@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 662fe90
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/68dff6d19b4f0c0008cbc7de
😎 Deploy Preview https://deploy-preview-20647--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 662fe90
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/68dff6d101e3b00008fd7961
😎 Deploy Preview https://deploy-preview-20647--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 662fe90
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/68dff6d1034ab50008e82f9a
😎 Deploy Preview https://deploy-preview-20647--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.11%. Comparing base (30b4f87) to head (662fe90).
⚠️ Report is 261 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20647      +/-   ##
==========================================
+ Coverage   91.39%   92.11%   +0.71%     
==========================================
  Files         485      492       +7     
  Lines       31370    34352    +2982     
  Branches     5430     5586     +156     
==========================================
+ Hits        28670    31642    +2972     
- Misses       2547     2563      +16     
+ Partials      153      147       -6     
Flag Coverage Δ
main-packages 85.34% <ø> (+0.40%) ⬆️
web-components 97.06% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@devadula-nandan
Copy link
Contributor Author

vrt shard 3/4 didn't complete
Error: page.goto: net::ERR_INSUFFICIENT_RESOURCES at http://localhost:3000/iframe?id=components-tabs--contained-full-width&viewMode=story&globals=theme:g10

can anyone restart it?

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! I restarted the vrt job

Copy link
Contributor

@maradwan26 maradwan26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maradwan26 maradwan26 added this pull request to the merge queue Oct 6, 2025
Merged via the queue into carbon-design-system:main with commit 8f38d05 Oct 6, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: storybook doc previews are not theme aware

3 participants