Skip to content

Conversation

@matthewgallo
Copy link
Member

Fixes broken images in about modal story

What did you change?

Update about modal story to import tech logos from local story assets directory.

How did you test and verify your work?

Storybook

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request section of
our contributing docs.

@matthewgallo matthewgallo requested a review from a team as a code owner June 19, 2025 20:32
@matthewgallo matthewgallo requested review from anamikaanu96 and makafsal and removed request for a team June 19, 2025 20:32
@netlify
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 01aba9a
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/685473c15a24ed00089fe0ea
😎 Deploy Preview https://deploy-preview-7712--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 01aba9a
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/685473c1f350b80008f3db32
😎 Deploy Preview https://deploy-preview-7712--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (ffae91a) to head (01aba9a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7712      +/-   ##
==========================================
+ Coverage   84.41%   84.42%   +0.01%     
==========================================
  Files         428      428              
  Lines       17730    17730              
  Branches     4716     4716              
==========================================
+ Hits        14966    14968       +2     
+ Misses       2764     2762       -2     
Components Coverage Δ
ibm-products 82.00% <ø> (+0.01%) ⬆️
ibm-products-web-components 91.88% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was working when I changed to hostedUrls in the PR 🤔

Now its working as expected in Storybook, but not in StackBlitz due to missing asset imports.

To ensure its works in both environments, as mentioned earlier, we could collaborate with a designer to optimize and reduce the file sizes. For example, the Grafana and Ansible logos exceed 70KB, which is likely why they are served via hosted URLs instead of being inlined as Base64.

Base64 is not causing any issue for other two logo's.

#7479 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants