-
Notifications
You must be signed in to change notification settings - Fork 153
fix(AboutModal): update stories to import local assets #7712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(AboutModal): update stories to import local assets #7712
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7712 +/- ##
==========================================
+ Coverage 84.41% 84.42% +0.01%
==========================================
Files 428 428
Lines 17730 17730
Branches 4716 4716
==========================================
+ Hits 14966 14968 +2
+ Misses 2764 2762 -2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was working when I changed to hostedUrls in the PR 🤔
Now its working as expected in Storybook, but not in StackBlitz due to missing asset imports.
To ensure its works in both environments, as mentioned earlier, we could collaborate with a designer to optimize and reduce the file sizes. For example, the Grafana and Ansible logos exceed 70KB, which is likely why they are served via hosted URLs instead of being inlined as Base64.
Base64 is not causing any issue for other two logo's.
Fixes broken images in about modal story
What did you change?
Update about modal story to import tech logos from local story assets directory.
How did you test and verify your work?
Storybook
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeMore details can be found in the pull request section of
our contributing docs.