Skip to content

Conversation

@matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Aug 14, 2025

Closes #8024

📢 This branches off #7956 which should be reviewed and merged before this PR

This replaces our rollup build setup with tsdown for both react and web components. There was a noticeable improvement in the react build times (~25 seconds down to ~3.5 seconds). The web component package requires some sass transformation in order to map the sass files into lit templates which uses sass.render which is very slow and also deprecated. If we could find a faster alternative to sass.render the web components package would likely see stronger improvements.

What did you change?

packages/ibm-products/tsdown.config.ts
packages/ibm-products/package.json
packages/ibm-products-web-components/tsdown.config.ts
packages/ibm-products-web-components/package.json
yarn.lock

*Deleted previous rollup build scripts for both react and web component packages

How did you test and verify your work?

Manually ran builds for both react and web component packages

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request section of
our contributing docs.

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 5eef4e6
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/689d55211d4dea0008d054e0
😎 Deploy Preview https://deploy-preview-8065--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 5eef4e6
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/689d5521c39b840008874ab8
😎 Deploy Preview https://deploy-preview-8065--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.21%. Comparing base (1c4fa62) to head (5eef4e6).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8065      +/-   ##
==========================================
- Coverage   79.38%   79.21%   -0.17%     
==========================================
  Files         474      475       +1     
  Lines       20340    20517     +177     
  Branches     5006     5024      +18     
==========================================
+ Hits        16146    16253     +107     
- Misses       4194     4264      +70     
Components Coverage Δ
ibm-products 80.48% <71.79%> (-0.10%) ⬇️
ibm-products-web-components 76.44% <68.30%> (-0.28%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[React]: Migrate current project build script to rolldown or tsdown

1 participant