-
Couldn't load subscription status.
- Fork 154
feat(build): adopt tsdown for builds
#8065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(build): adopt tsdown for builds
#8065
Conversation
…llo/ibm-products into 7953-rolldown-vite-integration
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8065 +/- ##
==========================================
- Coverage 79.38% 79.21% -0.17%
==========================================
Files 474 475 +1
Lines 20340 20517 +177
Branches 5006 5024 +18
==========================================
+ Hits 16146 16253 +107
- Misses 4194 4264 +70
🚀 New features to boost your workflow:
|
Closes #8024
📢 This branches off #7956 which should be reviewed and merged before this PR
This replaces our rollup build setup with
tsdownfor both react and web components. There was a noticeable improvement in the react build times (~25 seconds down to ~3.5 seconds). The web component package requires some sass transformation in order to map the sass files into lit templates which usessass.renderwhich is very slow and also deprecated. If we could find a faster alternative tosass.renderthe web components package would likely see stronger improvements.What did you change?
How did you test and verify your work?
Manually ran builds for both react and web component packages
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request section of
our contributing docs.