Skip to content

Conversation

@jlongshore
Copy link
Contributor

@jlongshore jlongshore commented Sep 10, 2025

Closes #8031

Dynamically added components causing multiple scrollbars

What did you change?

  • Modified Tearsheet scss
  • Updated snapshots

How did you test and verify your work?

  • Running tests
  • Visual checks in Storybook
  • Added modified code to Stackblitz supplied by bug reporter - but unsure if the dynamic nature of the example is a true representation of the application or just an example that displayed the scrollbars...

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request section of
our contributing docs.

@netlify
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 1256308
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/6903d8e710b0ba000873826e
😎 Deploy Preview https://deploy-preview-8227--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 1256308
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/6903d8e75331f60007d314f9
😎 Deploy Preview https://deploy-preview-8227--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.91%. Comparing base (f991fc1) to head (1256308).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8227   +/-   ##
=======================================
  Coverage   83.91%   83.91%           
=======================================
  Files         394      394           
  Lines       17944    17944           
  Branches     4165     4165           
=======================================
  Hits        15057    15057           
  Misses       2887     2887           
Components Coverage Δ
ibm-products 81.98% <ø> (ø)
ibm-products-web-components 86.72% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jlongshore jlongshore marked this pull request as ready for review September 10, 2025 18:29
@jlongshore jlongshore requested a review from a team as a code owner September 10, 2025 18:29
@jlongshore jlongshore requested review from amal-k-joy and anamikaanu96 and removed request for a team September 10, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tearsheet component issue

1 participant