- 
                Notifications
    You must be signed in to change notification settings 
- Fork 154
fix(Tearsheet): Tearsheet scroll issue with dynamic elements #8227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            jlongshore
  wants to merge
  6
  commits into
  carbon-design-system:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
jlongshore:tearsheet_scroll_8031
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            fix(Tearsheet): Tearsheet scroll issue with dynamic elements #8227
                    jlongshore
  wants to merge
  6
  commits into
  carbon-design-system:main
from
jlongshore:tearsheet_scroll_8031
  
      
      
   
              
            
      
        
          +11
        
        
          −2
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …ght integrity and hide the body container overflow
| ✅ Deploy Preview for ibm-products-web-components ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| ✅ Deploy Preview for carbon-for-ibm-products ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##             main    #8227   +/-   ##
=======================================
  Coverage   83.91%   83.91%           
=======================================
  Files         394      394           
  Lines       17944    17944           
  Branches     4165     4165           
=======================================
  Hits        15057    15057           
  Misses       2887     2887           
 🚀 New features to boost your workflow:
 | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Closes #8031
Dynamically added components causing multiple scrollbars
What did you change?
How did you test and verify your work?
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeAddressed any impact on accessibility (a11y)More details can be found in the pull request section of
our contributing docs.