8401 fix tagset tag spacing #8547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-balchin-ibm
requested review from
matthewgallo and
szinta
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| // The block part of our conventional BEM class names (blockClass__E--M). | ||
| $block-class: #{c4p-settings.$pkg-prefix}--tag-overflow; | ||
| $block-class-overflow: #{$block-class}-popover; | ||
| $block-class: #{$pkg-prefix}--tag-overflow; |
There was a problem hiding this comment.
Replaced c4p-settings.$pkg-prefix with $pkg-prefix to be more inline with other files.
| $block-class: #{c4p-settings.$pkg-prefix}--tag-overflow; | ||
| $block-class-overflow: #{$block-class}-popover; | ||
| $block-class: #{$pkg-prefix}--tag-overflow; | ||
| $block-class-popover: #{$block-class}-popover; |
There was a problem hiding this comment.
Matched popover with popover.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
| const defaultPet = { | ||
| patientId: crypto.randomUUID(), | ||
| patientId: Math.floor(Math.random() * 100000000000), |
Check failure
Code scanning / CodeQL
Insecure randomness High
This reverts commit e8abbd0.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8547 +/- ##
==========================================
+ Coverage 79.38% 85.49% +6.11%
==========================================
Files 474 364 -110
Lines 20340 17294 -3046
Branches 5006 4061 -945
==========================================
- Hits 16146 14785 -1361
+ Misses 4194 2509 -1685
🚀 New features to boost your workflow:
|
|
Horrendous merge conflict. Closing and recreating PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Fixes a previous build(deps) update #8347 that broke spacing between tags in tagsets.
NOTE: There were inconsistencies in spacing between tags in previous builds, both horizontally and vertically. Although
4px marginswere applied correctly, they are not 100% compatible with flexbox. Because of this sometimes themarginsdid not overlap properly and resulted in8pxof space. Everything in this PR has been normalized to4px.What did you change?
Products, React:
packages/ibm-products-styles/src/components/TagSet/_tag-set.scsspackages/ibm-products-styles/src/components/FilterSummary/_filter-summary.scsspackages/ibm-products-styles/src/components/TagOverflow/_tag-overflow.scsspackages/ibm-products-styles/src/components/PageHeader/_page-header.scssProducts, Web Components
packages/ibm-products-web-components/src/components/page-header/_story-assets/set-of-tags/set-of-tags.scsspackages/ibm-products-web-components/examples/set-of-tags/src/set-of-tags.scsspackages/ibm-products-web-components/examples/set-of-users/src/set-of-users.scsspackages/ibm-products-web-components/src/utilities/overflow-handler/story-styles.scssHow did you test and verify your work?
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request section of
our contributing docs.
Screenshots
Previous builds on the left, latest changes on the right.