Skip to content

[jhw] DynamoDb Local support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[jhw] DynamoDb Local support #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
644a0cb
[jhw] allow override of aws endpoint
jweissBHG Jul 19, 2020
a2f8718
[jhw] keep backwards compatibility
jweissBHG Jul 19, 2020
1647180
[jhw] no default nulls
jweissBHG Jul 19, 2020
3cdb4a8
Merge branch 'master' into dynamo-db-local-support
jweissBHG Jul 20, 2020
a8e34b8
[jhw] backwards compatibility with constructor
jweissBHG Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/Amazon.Core/Models/AwsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,24 @@ public abstract class AwsClient
protected readonly IAwsCredential credential;

public AwsClient(AwsService service, AwsRegion region, IAwsCredential credential)
: this(service, region, credential, (string?)null) { }

public AwsClient(AwsService service, AwsRegion region, IAwsCredential credential, HttpClient httpClient)
: this(service, region, credential, httpClient, null) { }

public AwsClient(AwsService service, AwsRegion region, IAwsCredential credential, HttpClient httpClient, string? endpoint)
: this(service, region, credential, endpoint)
{
this.httpClient = httpClient ?? throw new ArgumentNullException(nameof(httpClient));
}

public AwsClient(AwsService service, AwsRegion region, IAwsCredential credential, string? endpoint)
{
this.service = service ?? throw new ArgumentNullException(nameof(service));
Region = region ?? throw new ArgumentNullException(nameof(region));
this.credential = credential ?? throw new ArgumentNullException(nameof(credential));

Endpoint = $"https://{service.Name}.{region.Name}.amazonaws.com/";
Endpoint = endpoint ?? $"https://{service.Name}.{region.Name}.amazonaws.com/";

this.httpClient = new HttpClient(new HttpClientHandler {
AutomaticDecompression = DecompressionMethods.GZip
Expand All @@ -33,15 +45,7 @@ public AwsClient(AwsService service, AwsRegion region, IAwsCredential credential
};
}

public AwsClient(AwsService service, AwsRegion region, IAwsCredential credential, HttpClient httpClient)
{
this.service = service ?? throw new ArgumentNullException(nameof(service));
Region = region ?? throw new ArgumentNullException(nameof(region));
this.credential = credential ?? throw new ArgumentNullException(nameof(credential));
this.httpClient = httpClient ?? throw new ArgumentNullException(nameof(httpClient));

Endpoint = $"https://{service.Name}.{region.Name}.amazonaws.com/";
}


public string Endpoint { get; }

Expand Down
5 changes: 4 additions & 1 deletion src/Amazon.DynamoDb/DynamoDbClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ public sealed class DynamoDbClient : AwsClient
};

public DynamoDbClient(AwsRegion region, IAwsCredential credential)
: base(AwsService.DynamoDb, region, credential)
: this(region, credential, null) { }

public DynamoDbClient(AwsRegion region, IAwsCredential credential, string? endpoint)
: base(AwsService.DynamoDb, region, credential, endpoint)
{
httpClient.Timeout = TimeSpan.FromSeconds(10);
}
Expand Down