CIP-0153 | Add range limits to amounts in builtin Value #1095
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphair
added
Update
rphair
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
I'm approving this as a matter of course (and tagging Last Check which can be repealed upon any objection) following from #1088 (comment) on the already merged update, while also looking forward to review from those tagged. With sufficient confirmation we can put this though by the next CIP meeting: https://hackmd.io/@cip-editors/122
colll78
approved these changes
Oct 16, 2025
Crypto2099
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes costing much easier, since
unionValueinvolves integer addition. If we allow unbounded integers, then the integer sizes would need to be taken into account.The Int128 range is chosen because the ledger allows amounts up to 264-1. However builtin Values may be used for intermediate computation where the amounts temporarily exceed that limit. So to be safe we propose using [-2127, 2127-1].
cc @colll78 @kwxm @ana-pantilie @effectfully @Unisay @basetunnel @fallen-icarus @SeungheonOh @MicroProofs