set global header flag for all media types #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the output format requires global headers,
CODEC_FLAG_GLOBAL_HEADER should be set for all codec media types.
This appears to be a very old bug, inherited from the 2009 version of output_example.c
This fix uses the same approach currently in new_output_stream()
in both avconv_opt.c and ffmpeg_opt.c (just search for CODEC_FLAG_GLOBAL_HEADER)
It is also present in a slightly different form in add_audio_stream() of libavformat/output-example.c
see: libav change 073189917e4dfa0640e8180110b07e130471f37f
Make output-example.c handle AAC audio.
Patch by Martin Storsjö martin martin st
Originally committed as revision 21367 to svn://svn.ffmpeg.org/ffmpeg/trunk