[VM2] Support authorization keys #5326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpapierski
reviewed
Sep 26, 2025
executor/wasm/src/lib.rs
Outdated
| .with_parent_block_hash(parent_block_hash) | ||
| .with_block_height(block_height) | ||
| .with_runtime_native_config(runtime_native_config) | ||
| .with_authorization_keys(BTreeSet::from_iter([initiator])) |
There was a problem hiding this comment.
You should also support authorization keys in the installer
executor/wasm/src/lib.rs
Outdated
Comment on lines
900
to
904
| let authorization_keys = if authorization_keys.is_empty() { | ||
| BTreeSet::from_iter([initiator]) | ||
| } else { | ||
| authorization_keys | ||
| }; |
There was a problem hiding this comment.
That seems unnecessary - wouldn't VM1 just take authorization keys, and handle the initiator case inside?
mpapierski
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threads authorization_keys into the VM2 context and executor, forwards them in all appropriate subcalls