fix ubuntu 24.04 netcat installation #148
Open
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netcat is a virtual package on Ubuntu 24.04 Install `netcat-openbsd` as preferred by Ubuntu
| && mv "/tmp/toolset.new.json" "/imagegeneration/toolset.json" | ||
| ;; | ||
| *) ;; | ||
| esac |
There was a problem hiding this comment.
I think all Ubuntu releases onward have this new package name:
Suggested change
| esac | |
| UBUNTU_MAJOR=${VERSION_ID%%.*} | |
| if (( UBUNTU_MAJOR >= 24 )); then | |
| jq '.apt.cmd_packages |= map(if . == "netcat" then "netcat-openbsd" else . end)' "/imagegeneration/toolset.json" > "/tmp/toolset.new.json" \ | |
| && mv "/tmp/toolset.new.json" "/imagegeneration/toolset.json" | |
| fi |
There was a problem hiding this comment.
Unfortunately GitHub still has bugs, even when I select the correct lines 🤷
UBUNTU_MAJOR=${VERSION_ID%%.*}
if (( UBUNTU_MAJOR >= 24 )); then
jq '.apt.cmd_packages |= map(if . == "netcat" then "netcat-openbsd" else . end)' "/imagegeneration/toolset.json" > "/tmp/toolset.new.json" \
&& mv "/tmp/toolset.new.json" "/imagegeneration/toolset.json"
fiThere was a problem hiding this comment.
That is fine for me as well - do you want me to integrate this patch?
There was a problem hiding this comment.
If you want to, yes, then Ubuntu 25+ would be working too 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netcat is a virtual package on Ubuntu 24.04
Install
netcat-openbsdas preferred by UbuntuThis should fix #147