-
Notifications
You must be signed in to change notification settings - Fork 700
Add NSIS Windows installer #1645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
One question, I assume this causes problems with the auto-updater in Cemu since by default there is no write access to
The original file is GPLv2 licensed which is incompatible with our MPL-2.0 license. I assume you are not the original author (or at least not the only one), so there are multiple ways to solve this:
|
Overlooked that, that is indeed an issue and updates do not progress without opening as administrator. The already running process cannot be elevated, so to do it smoothly, having it in Program Files would require splitting out the updater into a separate exe that would be requested to run as administrator, or making the updater detect if the installed version is used and instead download and run the newest installer. The installer gives the choice of both installing system-wide ( In regard to license, I have now asked in Dolphin and Azahar for permission of use.
Can I simply use the original GPL-2 license for this file? |
Short answer is no, we cannot include a GPL-2 source file. Some other licenses are compatible (like BSD and MIT) hence the paragraph you quoted, but GPL is very strict in it's copyleft requirements. |
I have contacted the earliest documented author Installer is changed to be user-only, and I now actually don't see any need for a system-wide one in this case. Also made several improvements and cleanups, fixed things I missed, plus mentioned in the README that it is available as both installer and portable. Did some more throughout testing with it and would say that it is in a mature state! |
License, user-install only and cleanups, mention in README
04b4bba
to
dd69781
Compare
Addition of an NSIS Windows installer to Cemu's build and distribution. Addresses #1491
Installers are more familiar to many Windows users and have the following benefits:
AppData\Roaming
remain untouchedAppData\Local
, rather than just leaving it float in Downloads or Documents, which is true for most users.wud, .wux, .wua
) to be opened with CemuThe
.nsi
file is based upon the one from Azahar (originally taken from Dolphin), which I have touched-up recently.Tested and verified as working.
I have also adjusted spacing for consistency in the build files.