- 
                Notifications
    You must be signed in to change notification settings 
- Fork 23
More dependency reduction #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Mooncake.jl documentation for PR #785 is available at: | 
| Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! | 
| Performance Ratio:  | 
| To clarify, does this fix the underministisism of  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 
 This will not. This should (hopefully) just stop the benchmark suite occassionally erroring on  | 
Please do not review -- need to see if CI still passes.This seems to work nicely. Unlike #782 , this won't actually change what code gets loaded, because ChainRules depends on GPUArraysCore. This is therefore essentially just some rather trivial house keeping.
edit: this now also deals with some non-determinism in the benchmark suite where (I think) certain functions were getting run different amount of time on each run and, as a result, sometimes causing errors. We shall see.
edit2: the hand-written rule benchmarks now run quite a bit faster, because I've reduced the amount of time spent on each benchmark case. It looks like the test suite passed on this run, suggesting that doing this hasn't massively increased the variability in how long things take to run.