Skip to content

Conversation

yebai
Copy link
Member

@yebai yebai commented Sep 27, 2025

No description provided.

Removed unused function should_run_benchmark.

Signed-off-by: Hong Ge <[email protected]>
Copy link
Contributor

Mooncake.jl documentation for PR #788 is available at:
https://chalk-lab.github.io/Mooncake.jl/previews/PR788/

Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yebai yebai closed this Sep 27, 2025
@yebai yebai deleted the enzyme branch September 27, 2025 21:54
@yebai yebai restored the enzyme branch September 28, 2025 14:59
@yebai
Copy link
Member Author

yebai commented Sep 28, 2025

@penelopeysm, can you help take a look at why Enzyme is broken for the Turing broadcasting example? Let's figure out whether this is an incorrect use of the Enzyme API or a genuine limitation of Enzyme.

* Mark DPPL model as Const for Enzyme

* Format
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬──────────┬─────────────┬─────────┬─────────────┬────────┐
│                      Label │   Primal │ Mooncake │ MooncakeFwd │  Zygote │ ReverseDiff │ Enzyme │
│                     String │   String │   String │      String │  String │      String │ String │
├────────────────────────────┼──────────┼──────────┼─────────────┼─────────┼─────────────┼────────┤
│                   sum_1000 │ 100.0 ns │      1.8 │         1.9 │     1.1 │        5.61 │   8.31 │
│                  _sum_1000 │ 941.0 ns │     6.49 │        1.01 │  1420.0 │        32.4 │   1.09 │
│               sum_sin_1000 │  6.57 μs │     2.58 │        1.38 │    1.71 │        10.6 │   2.19 │
│              _sum_sin_1000 │  5.34 μs │     2.97 │        2.14 │   265.0 │        12.9 │   2.43 │
│                   kron_sum │ 333.0 μs │     39.5 │        2.61 │    4.74 │       191.0 │    8.1 │
│              kron_view_sum │ 340.0 μs │     40.0 │         3.3 │    10.7 │       205.0 │   11.8 │
│      naive_map_sin_cos_exp │  2.25 μs │     2.25 │        1.33 │ missing │        7.17 │   2.26 │
│            map_sin_cos_exp │  2.12 μs │     2.66 │        1.44 │    1.49 │        6.06 │   2.36 │
│      broadcast_sin_cos_exp │  2.25 μs │     2.38 │        1.38 │    2.29 │        1.47 │   2.24 │
│                 simple_mlp │ 163.0 μs │     7.02 │        2.97 │     1.8 │        12.6 │   3.29 │
│                     gp_lml │ 190.0 μs │     10.5 │        2.37 │    4.43 │     missing │   5.59 │
│ turing_broadcast_benchmark │  1.95 ms │     4.34 │        3.12 │ missing │        24.2 │   2.03 │
│         large_single_block │ 380.0 ns │     4.53 │        2.03 │  4540.0 │        32.4 │   2.24 │
└────────────────────────────┴──────────┴──────────┴─────────────┴─────────┴─────────────┴────────┘

@yebai yebai changed the title [don't merge] try enable enzyme for Turing example Enable enzyme for Turing example Sep 30, 2025
@yebai yebai requested a review from sunxd3 September 30, 2025 15:00
Copy link
Collaborator

@sunxd3 sunxd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue.

(Maybe update the description to "enable Enzyme benchmark", should_run_benchmark is not really unused.)

@sunxd3
Copy link
Collaborator

sunxd3 commented Oct 1, 2025

maybe let CI run and see if new benchmarks are produced

@yebai
Copy link
Member Author

yebai commented Oct 1, 2025

update the description to "enable Enzyme benchmark", should_run_benchmark is not really unused.)

Yes, there is a generic fallback for should_run_benchmark, so this PR doesn't remove it.

@yebai yebai merged commit 861d1c1 into main Oct 1, 2025
90 checks passed
@yebai yebai deleted the enzyme branch October 1, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants