Removed dependency on mta_common_functions #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for Issue #9. It accomplishes Objective 1) Remove dependency on mta_common_functions in
create_predicted_solar_wind_plot.py. The mta package was used only once, inread_gsme_data()function to read a text file, which is now accomplished withnp.loadtxt. This PR contributes also to Objective 5) Simplify inputs/outputs of functions, although significantly more work is needed to complete Objective 5. Additional changes include general editing of comments, syntax, and definitions of module constants, to conform to the SOT standards.Testing:
Fetch the
solwin-remove-mcfbranch and checkout to this branch.Create a directory for test plots, e.g. <path_of_your_choice>/test_plots. Create directories SOHO and SOHO/Plot inside the test plot directory.
import create_predicted_solar_wind_plot as cccc.html_dir = "<path_of_your_choice>/test_plots/"
cc.create_predicted_solar_wind_plot()
Compare the resulting plot with that displayed on https://cxc.cfa.harvard.edu/mta/RADIATION_new/SOHO/solwin.html and that attached below (created on Aug 29, 2023, at 7:33pm local time).
