-
Notifications
You must be signed in to change notification settings - Fork 12k
docs: Add Subresource Integrity (SRI) examples for CDN security #12121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,37 @@ Chart.js built files are also available through [jsDelivr](https://www.jsdelivr. | |
|
||
<https://www.jsdelivr.com/package/npm/chart.js?path=dist> | ||
|
||
## Security Considerations | ||
|
||
When loading Chart.js from a CDN, it's recommended to use **Subresource Integrity (SRI)** to protect against tampered or malicious scripts. Here are secure examples: | ||
|
||
### CDNJS with SRI | ||
|
||
```html | ||
<script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/4.5.0/chart.min.js" | ||
integrity="sha512-n/G+dROKbKL3GVngGWmWfwK0yPctjZQM752diVYnXZtD/48agpUKLIn0xDQL9ydZ91x6BiOmTIFwWjjFi2kEFg==" | ||
crossorigin="anonymous" | ||
referrerpolicy="no-referrer"> | ||
</script> | ||
``` | ||
|
||
### jsDelivr with SRI | ||
|
||
```html | ||
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/chart.min.js" | ||
integrity="sha512-n/G+dROKbKL3GVngGWmWfwK0yPctjZQM752diVYnXZtD/48agpUKLIn0xDQL9ydZ91x6BiOmTIFwWjjFi2kEFg==" | ||
crossorigin="anonymous" | ||
referrerpolicy="no-referrer"> | ||
</script> | ||
``` | ||
|
||
**Benefits of SRI:** | ||
- Prevents execution of tampered scripts from CDNs | ||
- Protects against supply chain attacks | ||
- Ensures script integrity in production environments | ||
|
||
You can generate integrity hashes for any Chart.js version using tools like [SRI Hash Generator](https://www.srihash.org/) or find them on [cdnjs.com](https://cdnjs.com/libraries/Chart.js). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The part about using external tools should be removed and only the part of keeping the hash of the CDN should be used. |
||
|
||
## GitHub | ||
|
||
[](https://github.com/chartjs/Chart.js/releases/latest) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this feature is not CDN specific and both CDN's are already described above I would keep this generic and just show a default config