pycriu: better use_binary errors handling
#2801
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a wrapper we don't check for sudo on every connection, but ensure users won't get an Unknown error trying to use the API without sudo. Signed-off-by: Andrii Herheliuk <[email protected]>
herheliuk
force-pushed
the
pycriu-use-binary-error-handling
branch
from
f080e58 to
056bf78
Compare
herheliuk
changed the title
use_binary errors handling
|
Before: CHECK failed: Error(0): UnknownAfter: CHECK failed with internal error: Please run with sudo or use service socket instead.Note that P.S. You are very welcome ^^ |
|
criu can work without sudo (6a30c7d). |
Yes, and this check is only when using pycriu with use_binary
When I tested it I was always getting an error using it via binary without sudo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a wrapper we don't check for sudo on every connection, but
ensure users won't get an Unknown error trying to use the API without sudo.
Signed-off-by: Andrii Herheliuk [email protected]