- 
                Notifications
    You must be signed in to change notification settings 
- Fork 78
Add logical block syntax and multiline inputs to skip and externals #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logical block syntax and multiline inputs to skip and externals #1213
Conversation
The action previously only allowed skip to be a boolean, string, or empty. It now allows skip to contain boolean, string, an array of strings, or a block literal. If an array or block literal is specified, it will utilize these as though they are OR components of the glob selector. Fixes CAP-3601.
This adds the ability to provide logical block (in github actions yaml) and multi-line inputs, where arrays will be concatenated together using the pipe operator to form a glob of the form "@(arrayElement[0]|arrayElement[1]|...)". Refs CAP 3601.
| 📦 Package Size: 5628 KB | 
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   71.62%   72.30%   +0.68%     
==========================================
  Files         204      205       +1     
  Lines        7601     7658      +57     
  Branches     1362     1369       +7     
==========================================
+ Hits         5444     5537      +93     
+ Misses       2135     2099      -36     
  Partials       22       22              ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew! That's a big shift! Can you cut an action canary for testing?
Refs CAP-3601.
133a3b9    to
    6c26466      
    Compare
  
    | @jmhobbs Ok, I've published a canary action here: I don't know how to actually use it, though. | 
| Did some testing and the block syntax is working as expected already. | 
This adds multiline block input parsing to the
skipandexternalsobjects in github actions. It also parses to an array when these cases are detected.See CAP-3601.
📦 Published PR as canary version:
13.3.1--canary.1213.18503239069.0✨ Test out this PR locally via: