Skip to content

Conversation

@jwir3
Copy link
Contributor

@jwir3 jwir3 commented Oct 2, 2025

This adds multiline block input parsing to the skip and externals objects in github actions. It also parses to an array when these cases are detected.

See CAP-3601.

📦 Published PR as canary version: 13.3.1--canary.1213.18503239069.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

jwir3 added 2 commits October 2, 2025 10:34
The action previously only allowed skip to be a boolean, string, or
empty. It now allows skip to contain boolean, string, an array of
strings, or a block literal. If an array or block literal is specified,
it will utilize these as though they are OR components of the glob
selector.

Fixes CAP-3601.
This adds the ability to provide logical block (in github actions yaml)
and multi-line inputs, where arrays will be concatenated together using
the pipe operator to form a glob of the form
"@(arrayElement[0]|arrayElement[1]|...)".

Refs CAP 3601.
@jwir3 jwir3 requested a review from jmhobbs October 2, 2025 20:32
@jwir3 jwir3 added bug Classification: Something isn't working patch Auto: Increment the patch version when merged Support Priority labels Oct 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

📦 Package Size: 5628 KB

@jwir3 jwir3 added the release Auto: Create a `latest` release when merged label Oct 2, 2025
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 68.38235% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.30%. Comparing base (50d59a9) to head (6c26466).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
action-src/main.ts 0.00% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   71.62%   72.30%   +0.68%     
==========================================
  Files         204      205       +1     
  Lines        7601     7658      +57     
  Branches     1362     1369       +7     
==========================================
+ Hits         5444     5537      +93     
+ Misses       2135     2099      -36     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew! That's a big shift! Can you cut an action canary for testing?

@jwir3 jwir3 force-pushed the jwir3/cap-3601-cli-silent-failure-of-literal-block-style-because-is-not branch from 133a3b9 to 6c26466 Compare October 14, 2025 16:24
@jwir3
Copy link
Contributor Author

jwir3 commented Oct 14, 2025

@jmhobbs Ok, I've published a canary action here:
https://github.com/chromaui/action-canary

I don't know how to actually use it, though.

@codykaup
Copy link
Contributor

Did some testing and the block syntax is working as expected already.

@codykaup codykaup closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Classification: Something isn't working patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged Support Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants