Skip to content

Conversation

Priyadharshini16092002
Copy link

@Priyadharshini16092002 Priyadharshini16092002 commented Oct 10, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Description

Code changes have been implemented in accordance with the new playbook discussed.
The update includes fixes for three identified bugs in the fabric_info module.

Bug Fix:

  1. [fabric_info]: The module with timeout/retry/interval settings for waiting for the device present in the fabric does not work.
  2. [fabric_info]: The module does not function correctly with the parent "site_hierarchy" filter
  3. [fabric_info]: The module returns Union instead of Intersection for combined filters (site hierarchy, device role, ...)

Root Cause (if applicable): NA

Fix Implemented:

  1. Added proper handling for timeout, retry, and interval settings while waiting for devices to appear in the fabric.
  2. Enhanced logic to correctly identify and retrieve requested_info when the specified site is recognized as a fabric site.
  3. Modified the filter logic to return the intersection of devices when multiple filters (site_hierarchy, fabric_role, etc.) are applied simultaneously.

Enhancement: NA
Enhancement Description: NA
Impact Area: NA

Testing Done:

  • Manual testing
  • Unit tests
  • Integration tests

Test cases covered: [Mention test case IDs or brief points]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

@madhansansel madhansansel merged commit 7b33827 into cisco-en-programmability:main Oct 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants