do not use system include for srtp_priv.h #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including srtp_priv.h should only be done form inside source tree.
Member
Author
|
This is a small update to the merged PR #612, @mildsunrise or @bifurcation could you take a quick look, thanks. |
bifurcation
approved these changes
Jan 23, 2023
mildsunrise
approved these changes
Jan 23, 2023
sprintf is marked as deprecated in OSX 13.1
Member
Author
|
Push an extra change to fix CI, kind of sucks that CI breakage relating to the CI frame changes are not detected before a new PR is created, will look at running at least some of the CI work flows on a schedule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including srtp_priv.h should only be done form inside source tree.