Remove uses of strtok() and other global state in svm_load_model(). #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strtok() (as well as the internal readline() function) used global state, and therefore were not thread-safe. Replace them with reentrant equivalents. Thread-safety of loading was checked with valgrind's helgrind and drd tools. As an added bonus, the new tokenization functions are much faster than strtok(). In a benchmark with a large model, overall loading time decreased by 45% (1.1s vs 1.9s over 32 trials).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strtok() (as well as the internal readline() function) used global
state, and therefore were not thread-safe. Replace them with reentrant
equivalents. Thread-safety of loading was checked with valgrind's
helgrind and drd tools.
As an added bonus, the new tokenization functions are much faster than
strtok(). In a benchmark with a large model, overall loading time
decreased by 45% (1.1s vs 1.9s over 32 trials).