-
Notifications
You must be signed in to change notification settings - Fork 3
Add variables for feature control, connection customization, and Patroni integration #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would allow dynamically selecting what features to run instead of relying on tags [skip ci]
[skip ci]
… customization for the repo source on debian-like systems
[skip ci]
…atroni making the required parameters clearer
ElieDeloumeau
requested changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update introduces several enhancements to improve flexibility and integration:
postgresql_conn_vars
, which enables users to customize connection parameters when managing database objects on the local PostgreSQL instance. This is particularly useful for setups that do not support the default socket-based connection with the defaultpostgres
user.closes #10
closes #25
Motivation and Context
These changes enhance the role's configurability, making it easier to integrate with other tools and environments. It also resolves issues related to rigid defaults for PostgreSQL connections and prepares the role for compatibility with the upcoming Patroni integration.
How Has This Been Tested?
Tests performed with Molecule both locally and using Github Actions
Types of Changes
_postgresql_apt_repo_template_path
to allow full customization of the PostgreSQL APT repository.postgresql_conn_vars
to enable fully customizable local PostgreSQL connection settings.Checklist: