datastore: add support for truncation #3215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
changed the base branch from
master
to
centril/clear-table-and-fix-drop-table
Shubham8287
reviewed
Sep 2, 2025
gefjon
reviewed
Sep 2, 2025
Centril
force-pushed
the
centril/clear-table-and-fix-drop-table
branch
from
08b70cf to
813f34c
Compare
Centril
force-pushed
the
centril/truncate
branch
from
cc9ef87 to
a81d360
Compare
Centril
force-pushed
the
centril/truncate
branch
from
a81d360 to
2ed26ea
Compare
Shubham8287
reviewed
Sep 16, 2025
| @@ -345,19 +345,35 @@ impl CommittedState { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub(super) fn replay_truncate(&mut self, table_id: TableId) -> Result<()> { | |||
There was a problem hiding this comment.
visit_delete happens before visit_truncate, which removes rows from st_* tables, hence schema_for_table fails inside visit_truncate. I think we have to avoid calling that method.
Shubham8287
requested changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds support for truncation in the datastore.
The commitlog format already supported it.
A table is considered truncated in a transaction when there are deletes and when the row count post-deletes is 0.
API and ABI breaking changes
None
Expected complexity level and risk
3?
Testing
Some existing datastore tests have been amended to check whether
TxDatacontain truncation or not.