datastore: add columns support #3230
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shubham Mishra <[email protected]> Signed-off-by: Mazdak Farrokhzad <[email protected]>
Shubham8287
changed the base branch from
master
to
centril/clear-table-and-fix-drop-table
Shubham8287
force-pushed
the
shub/add-columns
branch
from
fb82b01 to
b7bb652
Compare
Shubham8287
commented
Sep 8, 2025
Shubham8287
commented
Sep 8, 2025
Centril
requested changes
Sep 8, 2025
Centril
force-pushed
the
centril/clear-table-and-fix-drop-table
branch
from
08b70cf to
813f34c
Compare
Centril
reviewed
Sep 16, 2025
|
|
||
| let mut tx = begin_mut_tx(&datastore); | ||
| // insert a row in tx_state when before adding column |
| @@ -3466,4 +3456,58 @@ mod tests { | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_table_schemas_consistency() -> ResultTest<()> { | |||
There was a problem hiding this comment.
Could you add some comments to the test, for example explaining what it tests, why 5000 is used, etc?
| let table_schema = tx.schema_for_table(table_id).unwrap(); | ||
| let table_schema_raw = tx.schema_for_table_raw(table_id).unwrap(); | ||
|
|
||
| //TODO: Fix the bug and update the assert |
There was a problem hiding this comment.
Can you file an issue for this and assign it to me?
| let default_value = default_values | ||
| .get(idx) | ||
| .ok_or_else(|| make_err(AddColumnsErrorReason::DefaultValueMissing(new_col.col_pos)))?; | ||
| if Some(new_col.col_type.clone()) != default_value.type_of() { |
There was a problem hiding this comment.
This is a sound check but its unnecessarily incomplete. Rather than using type_of, it would be better to introduce AlgebraicType::type_check to check if the value is compatible with the type. That would be a complete check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
add_columns_to_tableapi to handleAutoMigrateStep::AddColumns-- Look at doc comment for more Info.depends on: centril/clear-table-and-fix-drop-table
TODO: handle
AutoMigrateStep::DisconnectAllUsers.API and ABI breaking changes
N/A.
Expected complexity level and risk
2? Changes are not in hotpath but a bug in migration can corrupt tables.
Testing
a test to exercise the API.