Adds a non-repeating scheduled reducer test #3233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
reviewed
Sep 10, 2025
| public static void nonrepeating_test(ReducerContext ctx, NonrepeatingTestArg arg) | ||
| { | ||
| var deltaTime = ctx.Timestamp.TimeDurationSince(arg.prev_time); | ||
| Log.Trace($"Timestamp: {ctx.Timestamp}, Delta time: {deltaTime}"); |
There was a problem hiding this comment.
Where in the test harness do we actually check to see if we get this log? If this log isn't present how does the test fail?
jdetter
reviewed
Sep 10, 2025
| .timestamp | ||
| .duration_since(arg.prev_time) | ||
| .expect("arg.prev_time is later than ctx.timestamp... huh?"); | ||
| log::trace!( |
There was a problem hiding this comment.
Same here: Where in the test harness do we actually check to see if we get this log? If this log isn't present how does the test fail?
bfops
added
release-any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a non-repeating scheduled reducer integration test to the existing Rust and C# integration tests, in order to address #3213
API and ABI breaking changes
No
Expected complexity level and risk
1
Testing
cargo test -p spacetimedb-testingand all tests passed