Skip to content

Conversation

xSAVIKx
Copy link
Member

@xSAVIKx xSAVIKx commented May 31, 2025

Changes

Python 3.8 has reached EOL more than a year ago. Dropping support while other tooling is not supporting is anymore as well

  • Tests pass
  • Appropriate changes to README are included in PR

@xSAVIKx xSAVIKx requested a review from a team May 31, 2025 19:22
@xSAVIKx xSAVIKx self-assigned this May 31, 2025
Copy link

@Klaudioz Klaudioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is a good idea to add:

python_requires=">=3.9"

to setup.py

@xSAVIKx
Copy link
Member Author

xSAVIKx commented Jun 2, 2025

Maybe is a good idea to add:

python_requires=">=3.9"

to setup.py

Read on it a little bit. I'd rather not specify it. The package can be used with 3.8 and I believe even 3.7 it's just we don't support them officially anymore.

@xSAVIKx xSAVIKx requested a review from Klaudioz June 2, 2025 18:20
Copy link

@Klaudioz Klaudioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Klaudioz Klaudioz merged commit a38933d into main Jun 2, 2025
35 checks passed
@Klaudioz Klaudioz deleted the drop-python3.8 branch June 2, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants