wrangler: fix: preserve remote preview_urls status #10736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eed02e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danielrs
force-pushed
the
drivas/wrangler-keep-preview-urls-status-when-not-given
branch
from
695022b to
3c2a080
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
force-pushed
the
drivas/wrangler-keep-preview-urls-status-when-not-given
branch
from
3c2a080 to
88be05f
Compare
petebacondarwin
approved these changes
Sep 25, 2025
| Using default config 'workers_dev = true', current status will be overwritten. | ||
| " | ||
| `); |
There was a problem hiding this comment.
Delete this test if it is no longer relevant?
Did you just keep it here while the product change was discussed?
petebacondarwin
force-pushed
the
drivas/wrangler-keep-preview-urls-status-when-not-given
branch
from
88be05f to
b0d2125
Compare
|
For posterity Dina Kozlov approved this approach from a product perspective. |
|
@danielrs - the tick box in the description says docs are TBD. |
petebacondarwin
force-pushed
the
drivas/wrangler-keep-preview-urls-status-when-not-given
branch
from
b0d2125 to
71e378b
Compare
Fixes cloudflare#10722. Instead of defaulting to `false`, `preview_urls` will default to current remote status.
petebacondarwin
force-pushed
the
drivas/wrangler-keep-preview-urls-status-when-not-given
branch
from
71e378b to
eed02e9
Compare
|
Approved but waiting on docs @danielrs |
|
Closing in favor of #10939. |
danielrs
deleted the
drivas/wrangler-keep-preview-urls-status-when-not-given
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10722.
Describe your change...
Instead of defaulting to
false,preview_urlswill default to current remote status.