-
Couldn't load subscription status.
- Fork 1k
fix: prevent duplicate warning messages in wrangler dev (v3 backport) #10962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes all logger.warn() calls to logger.once.warn() in ConfigController.ts to ensure warnings are only shown once even when configuration is updated multiple times. Also adds a test to verify warnings are only logged once across multiple config updates. Backport of #10913 to v3-maintenance branch. Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: fca9859 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: [email protected] <[email protected]>
|
update this to match the original PR again |
|
Hi @emily-shen, I've reviewed the original PR #10913 to match it exactly. The original PR includes changes to However, I've discovered that the v3-maintenance branch's The current backport includes:
Should I:
Please let me know how you'd like me to proceed. Thanks! |
|
Ignoring the dev.test.ts changes is fine. The test in configcontroller.test.ts is not the same as in the original PR - it should be using the analytics engine binding |
a67e7ea to
fca9859
Compare
|
Congratulations @devin-ai-integration[bot], the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmhaf3w9000g0l404d767qwqf This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Backport of #10913 to v3-maintenance branch.
Fixes #6855
This PR addresses duplicate warning messages during
wrangler devby changing alllogger.warn()calls tologger.once.warn()in ConfigController.ts. When configuration is updated multiple times (common during development), the same warnings would be displayed repeatedly, creating noise in the console output.Changes
ConfigController.ts: Updated 4 warning scenarios to use
logger.once.warn():ConfigController.test.ts: Added test to verify warnings are only logged once across multiple config updates.
Testing Notes
Review Checklist
Link to Devin run: https://app.devin.ai/sessions/fe4aed656c5945a7adaa0078b1e9e9a8
Requested by: [email protected]