[Workflows] Enforce correct step limits and validations on local dev

[pombosilva]

Fixes WOR-957.

Some changes made to match production behaviors:

• Limit of 1024 steps is now enforced
• Don't free retry if the last attempt was due to internal errors
• Step errors are now being properly thrown to the user

---

• Tests
  • Tests included
  • Tests not necessary because: no tests needed, just a simple throw fix
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: no new features were added
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: Workflows were not GA in v3

[changeset-bot]

🦋 Changeset detected

Latest commit: fbcfdaa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10966

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10966

miniflare

npm i https://pkg.pr.new/miniflare@10966

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10966

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10966

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10966

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10966

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10966

wrangler

npm i https://pkg.pr.new/wrangler@10966

commit: fbcfdaa

[Caio-Nogueira]

abort is a no-op at the moment. From what I see, other usages of it don't throw the error to the caller. Imo you can remove the abort call here and just throw an error like: Aborting engine: Max steps reached. It diverges from production but at least the user is more likely to see the error (?)

[LuisDuarte1]

I think abort should be implemented for limits to work (otherwise how does one cancel engine execution?) - although we should probably try to hide all workerd noise that abort causes?

[pombosilva]

abort is not "aborting" (aka throwing) anything atm. I can make it throw and check the consequences, and (if possible) hide workerd noise