Feature: handle rate limiting of UAA server. Fix #1307 #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lokowandtg
requested review from
Kehrlann,
anthonydahanne,
beyhan and
s-yonkov-yonkov
Contributor
Author
|
Found an error, WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the UAA server is configured with rate limiting, too many parallel requests result in http-429 results. This will block integration tests, as they create a lot of groups in parallel during initialization.
With this pull request, first the rate limit value is requested from UAA. If ratelimiting is inactive, everything works as normal.
If there is a ratelimit, requests to UAA are limited to the allowed number of parallel requests. Excess requests are queued until a slot becomes free.
For testing purposes, the limit can be provided with the new environment variable
UAA_API_REQUEST_LIMIT. Value "0" means no rate limit, any other value gives the maximum number of parallel calls.In class integration-test/src/test/java/org/cloudfoundry/IntegrationTestConfiguration.java, some changes from a different pull request are copied to allow integration-test execution.