add github.com/prometheus/common/model to scraper and linting error t… #707
+18,847
−4,060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
chombium
requested changes
Sep 19, 2025
Contributor
There was a problem hiding this comment.
Hi @alchen1218
The missing function is included in Prometheus common used in the Prometheus client_golang which is included as indirect dependency. The e Prometheus client_golang comes as a dependency of the system-metrics-scraper-release and as the commit is pinned it should be updated to the latest commit as in the system-metrics-scraper-release release.
Then run:
go mod tidy
go mod vendorand the dependencies will be updated with which you will fix the compilation problems.
|
|
chombium
requested changes
Sep 19, 2025
Contributor
chombium
left a comment
chombium
left a comment
There was a problem hiding this comment.
@alchen1218 can you please check what's wrong with the CF Logging And Metrics CI Bot?
added 2 commits
September 29, 2025 08:47
chombium
approved these changes
Oct 8, 2025
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o fix test