Use golang/protobuf instead of gogo/protobuf #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
geofffranks
approved these changes
Feb 19, 2025
ebroberson
force-pushed
the
protobuf-with-plugin
branch
from
17cdcad to
55fe9c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gogo/protobuf has been deprecated for years. We should be using up-to-date protobufs provided by google.golang.org/protobuf. In order to fit our use cases, a protobuf plugin (
protoc-gen-go-bbs) has been created to catch any customizations we want to add.Backward Compatibility
Breaking Change? No