Skip to content

Conversation

jhb-dev
Copy link

@jhb-dev jhb-dev commented Apr 30, 2025

Description

This PR adjusts the CldVideoPlayer to add an event listener to astro:page-load instead of load to ensure the video player is also initialized when navigating to a page via the ClientRouter (View Transitions).

Issue Ticket Number

Fixes #90

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

Copy link

vercel bot commented Apr 30, 2025

@devj3ns is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CldVideoPlayer not initialized when navigating to a page via the client router (view transitions)
1 participant