2D Fit Functionality for HH #41
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR introduces 2D fit functionality from current HH analyses. It adds complementary fitting code to run parallel with the standard mgg pipeline. At the time it was first submitted, this PR is not complete, but remains in draft state to allow feedback from the FinalFit devs prior to merge and continued migration of the 2D code changes from a separate analysis-specific fork in Gitlab.
A few notes
CombineModels.py
CombineModels.py
acceptsmodels.json
files that hold 1D model information and paths to be collected for the 2D modelsmodels.json
Changes
CollectModels.py
2D workspace writermodels.json
writercommonObjects.py
)As commits are added to this PR, we will update the status. We would be grateful to have any feedback from the FinalFit developers to ensure the current code aligns with their vision for the flashggFinalFit package. If the changes are considered too disruptive for the main branch, we may propose adding a designated "2D branch" instead.