Skip to content

Conversation

lgray
Copy link

@lgray lgray commented Jun 7, 2025

Hi,

Making this PR in case it is of interest for CMS. The cmake install vastly simplifies the building and management of python bindings built here: https://github.com/scikit-hep/fastjet, perhaps similar justification exists here.

It's root-dir only + patchset for windows so that the code changes are minimal and it's easy to continue merging with updates from fjcontrib. The root CMakeLists.txt generates all subsequently required CMakeLists.txts in subdirectories. I have tested this on linux (x86 and arm), macos, and windows. All tests we could run pass.

Example configuration command, assuming fastjet and siscone are not in the CMAKE_PREFIX_PATH:

cmake -S . -B build -DCMAKE_INSTALL_PREFIX=INSTALL/PATH -Dfastjet_DIR=PATH/TO/lib/cmake/fastjet -Dsiscone_DIR=PATH/TO/lib/cmake/siscone -DFASTJETCONTRIB_ENABLE_FRAGILELIB=ON # (or OFF)

Presently this PR does not change the build process for the cms-external away from autotools, but merely enables the possibility of using cmake.

@cmsbuild
Copy link

cmsbuild commented Jun 7, 2025

A new Pull Request was created by @lgray for branch cms/v1.101.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link

cmsbuild commented Jun 7, 2025

cms-bot internal usage

@lgray lgray changed the title cmake-based build for fastjet-contrib (requires fastjet 3.5.0, siscone 3.1.1 also built with cmake) cmake-based build for fastjet-contrib (requires fastjet >=3.5.0, siscone >=3.1.1 also built with cmake) Jun 7, 2025
@lgray lgray changed the title cmake-based build for fastjet-contrib (requires fastjet >=3.5.0, siscone >=3.1.1 also built with cmake) cmake-based build for fastjet-contrib (cmake requires fastjet >=3.5.0, siscone >=3.1.1 also built with cmake) Jun 7, 2025
@lgray
Copy link
Author

lgray commented Jun 9, 2025

@smuzaffar any major reservations against this?

@cmsbuild
Copy link

Pull request #19 was updated.

@cmsbuild
Copy link

Pull request #19 was updated.

@cmsbuild
Copy link

Pull request #19 was updated.

@cmsbuild
Copy link

Pull request #19 was updated.

@cmsbuild
Copy link

Pull request #19 was updated.

@cmsbuild
Copy link

Pull request #19 was updated.

@cmsbuild
Copy link

Pull request #19 was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants