simple fix for division by zero in METTesterPostProcessor

[mmusich]

resolves #49073

PR description:

SImple fix for #49073, by acting on , #48745 (comment) avoiding division by zero, alternative to #49082.

PR validation:

runTheMatrix.py -l 12834.0 --ibeos -t 4 -j 8

runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[mmusich]

type bug-fix

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49102/46337

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Validation/RecoMET/plugins/METTesterPostProcessor.cc modified in PR(s): [Hotfix] MET Validation: Division by zero #49082

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• Validation/RecoMET (dqm)

@ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@ahinzmann, @gkasieczka, @jdamgov, @jdolen, @mariadalfonso, @mmarionncern, @nhanvtran, @schoef, @seemasharmafnal this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[nothingface0]

Why have two open PRs and not just converge on the already open one?

[mmusich]

Why have two open PRs and not just converge on the already open one?

because the currently open PR is not converging and IMHO it's a horrible solution.

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56dfad/48542/summary.html
COMMIT: a37cbfe
CMSSW: CMSSW_16_0_X_2025-10-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49102/48542/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3940073
• DQMHistoTests: Total failures: 396
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3939657
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 218 log files, 188 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mmusich]

just for the record the fix is effective, see e.g. https://cern.ch/28t8e (nan are gone).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49102/46343

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Validation/RecoMET/plugins/METTesterPostProcessor.cc modified in PR(s): [Hotfix] MET Validation: Division by zero #49082

[cmsbuild]

Pull request #49102 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

[mmusich]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56dfad/48547/summary.html
COMMIT: ba99f40
CMSSW: CMSSW_16_0_X_2025-10-08-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49102/48547/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3940073
• DQMHistoTests: Total failures: 453
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3939600
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 218 log files, 188 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[nothingface0]

#49082 has been approved, so this one can be closed

[mmusich]

as been approved, so this one can be closed

I would appreciate the rational behind that.

[nothingface0]

I would appreciate the rational behind that.

It addresses both issues that were introduced by the original author of the offending PRs (#48745, #49073).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49102/46394

[cmsbuild]

Pull request #49102 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56dfad/48601/summary.html
COMMIT: 21ee5b1
CMSSW: CMSSW_16_0_X_2025-10-10-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49102/48601/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3940073
• DQMHistoTests: Total failures: 62
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3939991
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 218 log files, 188 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[gabrielmscampos]

As far as I understood, this PR should not be needed anymore. Are there any arguments to have it merged, or can we have it closed?