Skip to content

Conversation

zhangm365
Copy link

set CMakeLists.txt output directory for executables "build/bin". It can avoid the compilation error:
"source file is not valid UTF-8".

@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 14:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a CMake configuration issue by setting the output directory for executables to "build/bin" to avoid compilation errors related to UTF-8 validation and potential name clashes with C++ standard headers.

  • Adds CMAKE_RUNTIME_OUTPUT_DIRECTORY setting to place executables in a dedicated subdirectory
  • Includes explanatory comment about avoiding name clashes with C++ standard headers like <mutex>

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant