Skip to content

Fix Clippy in shredding part 1: #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: shredding-variant-part1
Choose a base branch
from
Open

Fix Clippy in shredding part 1: #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 11 additions & 24 deletions parquet-variant-compute/src/variant_get/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,17 +1159,12 @@ mod test {
fn create_depth_1_shredded_test_data_working() -> ArrayRef {
// Create metadata following the working pattern from shredded_object_with_x_field_variant_array
let (metadata, _) = {
// Create nested structure: {"a": {"x": 55}, "b": 42}
let a_variant = {
let mut a_builder = parquet_variant::VariantBuilder::new();
let mut a_obj = a_builder.new_object();
a_obj.insert("x", Variant::Int32(55)); // "a.x" field (shredded when possible)
a_obj.finish().unwrap()
};

let mut builder = parquet_variant::VariantBuilder::new();
// Create nested structure: {"a": {"x": 55}, "b": 42}
let mut obj = builder.new_object();
obj.insert("a", a_variant);
let mut a_obj = obj.new_object("x");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the API for making nested structures appears to have changed, so I updated the tests to use the new API

a_obj.insert("x", Variant::Int32(55)); // "a.x" field (shredded when possible)
a_obj.finish().unwrap();
obj.insert("b", Variant::Int32(42));
obj.finish().unwrap();
builder.finish()
Expand Down Expand Up @@ -1273,23 +1268,15 @@ mod test {
// Create metadata following the working pattern
let (metadata, _) = {
// Create deeply nested structure: {"a": {"b": {"x": 100}}}
let b_variant = {
let mut b_builder = parquet_variant::VariantBuilder::new();
let mut b_obj = b_builder.new_object();
b_obj.insert("x", Variant::Int32(100));
b_obj.finish().unwrap()
};

let a_variant = {
let mut a_builder = parquet_variant::VariantBuilder::new();
let mut a_obj = a_builder.new_object();
a_obj.insert("b", b_variant);
a_obj.finish().unwrap()
};


let mut builder = parquet_variant::VariantBuilder::new();
// Create deeply nested structure: {"a": {"b": {"x": 100}}}
let mut obj = builder.new_object();
obj.insert("a", a_variant); // "a" field containing b
let mut a_obj = obj.new_object("a");
let mut b_obj = a_obj.new_object("b");
b_obj.insert("x", Variant::Int32(100)); // "a.b.x" field (shredded when possible)
b_obj.finish().unwrap();
a_obj.finish().unwrap();
obj.finish().unwrap();
builder.finish()
};
Expand Down
Loading