Skip to content

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 8, 2025

Backport 1/1 commits from #154789 on behalf of @mgartner.


This commit fixes a bug that was caused by incorrectly modifying the set
and list of target columns when re-projecting computed columns after
building a BEFORE trigger.

Fixes #154672

Release note (bug fix): A bug has been fixed that caused internal errors
for INSERT .. ON CONFLICT .. DO UPDATE statements when the target
table had both a computed column and a BEFORE trigger. This bug has
been present since triggers were introduced in v24.3.0.


Release justification: Low-risk bug fix.

@blathers-crl blathers-crl bot requested a review from a team as a code owner October 8, 2025 17:55
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-154789 branch from 81a2391 to 6856dca Compare October 8, 2025 17:55
@blathers-crl blathers-crl bot requested review from DrewKimball and removed request for a team October 8, 2025 17:55
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 8, 2025
@blathers-crl blathers-crl bot requested a review from mgartner October 8, 2025 17:55
Copy link
Author

blathers-crl bot commented Oct 8, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team labels Oct 8, 2025
Copy link
Author

blathers-crl bot commented Oct 8, 2025

❌ PR #155074 does not comply with backport policy

Confidence: high
Explanation: The PR does not meet the critical bug requirement under the backport policy, nor does it include a disabled feature flag to gate the changes. Although a bug that causes internal errors is addressed, this does not categorically fall under the specified critical bug criteria such as stability/security issues, data corruption/loss, significant performance regressions, incorrect results/suboptimal performance, or inability to debug production issues. The PR description mentions a 'Low-risk bug fix' which doesn't align with critical issues. Moreover, there is no evidence of this change being gated behind a feature flag. No new cluster or session settings are introduced that control the behavior of new features or changes. The changes are in production files and not exempt non-production paths.
Recommendation: Gate the PR behind a feature flag or reconsider the backport. Add a justification as to why this bug fix is critical that allows safe backporting without a feature flag.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner requested a review from michae2 October 8, 2025 20:07
This commit fixes a bug that was caused by incorrectly modifying the set
and list of target columns when re-projecting computed columns after
building a `BEFORE` trigger.

Fixes #154672

Release note (bug fix): A bug has been fixed that caused internal errors
for `INSERT .. ON CONFLICT .. DO UPDATE` statements when the target
table had both a computed column and a `BEFORE` trigger. This bug has
been present since triggers were introduced in v24.3.0.
@mgartner mgartner force-pushed the blathers/backport-release-24.3-154789 branch from 6856dca to cd4e314 Compare October 8, 2025 20:16
@mgartner
Copy link
Collaborator

mgartner commented Oct 8, 2025

The other backports passed the AI check, so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants