-
Notifications
You must be signed in to change notification settings - Fork 4k
release-24.3: opt: fix trigger+computed column internal error #155074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-24.3
Are you sure you want to change the base?
Conversation
81a2391
to
6856dca
Compare
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
❌ PR #155074 does not comply with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commit fixes a bug that was caused by incorrectly modifying the set and list of target columns when re-projecting computed columns after building a `BEFORE` trigger. Fixes #154672 Release note (bug fix): A bug has been fixed that caused internal errors for `INSERT .. ON CONFLICT .. DO UPDATE` statements when the target table had both a computed column and a `BEFORE` trigger. This bug has been present since triggers were introduced in v24.3.0.
6856dca
to
cd4e314
Compare
The other backports passed the AI check, so... |
Backport 1/1 commits from #154789 on behalf of @mgartner.
This commit fixes a bug that was caused by incorrectly modifying the set
and list of target columns when re-projecting computed columns after
building a
BEFORE
trigger.Fixes #154672
Release note (bug fix): A bug has been fixed that caused internal errors
for
INSERT .. ON CONFLICT .. DO UPDATE
statements when the targettable had both a computed column and a
BEFORE
trigger. This bug hasbeen present since triggers were introduced in v24.3.0.
Release justification: Low-risk bug fix.