Skip to content

Conversation

jeffswenson
Copy link
Collaborator

Backport 1/1 commits from #154687.

/cc @cockroachdb/release

Release justification: test only change.


Previously, the datadriven test harness would tear down clusters in order. This makes it difficult to troubleshoot stuck tear downs because there are goroutines for a running server mixed in with goroutines for a server with a stuck shutdown.

Release note: none
Informs: #145079

Previously, the datadriven test harness would tear down clusters in
order. This makes it difficult to troubleshoot stuck tear downs because
there are goroutines for a running server mixed in with goroutines for a
server with a stuck shutdown.

Release note: none
Informs: cockroachdb#145079
@jeffswenson jeffswenson requested a review from a team as a code owner October 8, 2025 20:39
@jeffswenson jeffswenson requested review from kev-cao and removed request for a team October 8, 2025 20:39
Copy link

blathers-crl bot commented Oct 8, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-disaster-recovery labels Oct 8, 2025
Copy link

blathers-crl bot commented Oct 8, 2025

✅ PR #155116 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR is modifying a test file with a *_test.go suffix, specifically datadriven_test.go within the pkg/ccl/backupccl directory. According to the backport policy, changes that only affect non-production code, tests, or development tools are exempt from the standard backport policy requirements. Therefore, this PR, which is described as a 'test only change' in the PR body, aligns with the exception for Non-Production and Test-Only Changes. It adds clarity to the test execution process without affecting production functionality.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Oct 8, 2025
@jeffswenson jeffswenson requested a review from msbutler October 9, 2025 13:40
@jeffswenson jeffswenson merged commit 4eb91dc into cockroachdb:release-24.3 Oct 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes T-disaster-recovery target-release-24.3.22

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants