asim: add asimdiff #155131
Merged
asim: add asimdiff #155131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Could you say a few more words about what this does and how one acts on its output? |
|
Did this for the thrashing PR (#154869 (comment) |
tbg
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Sure, let's merge it! I'm not going to review it since it's a little AI-genned tool, but lmk if there's something I should be looking at.
Looks like lint failed, but I imagine this might have been an infra flake (saw many browned-out runners today), but please take a look before bors.
This commit introduces a adds a python script that pipes git diffs to compare certain metrics sum diff. Generated by claude. Sample usage: ``` git diff | python3 pkg/kv/kvserver/asim/tests/cmd/asimdiff.py thrash_pct git diff head~1 head | python3 pkg/kv/kvserver/asim/tests/cmd/asimdiff.py last --metric mean ``` Sample output: ``` [skewed_cpu_skewed_write.txt] before = 249%, after = 249%, diff = +0% cpu_util#5: thrash_pct: [s1=40%, s2=76%, s3=49%, s4=30%, s5=33%, s6=21%] (sum=249%) ... total diff = -5374% (total before = 498950%, total after = 493576%) percent change = -1.1% avg diff = -22.7%, max diff = +7824%, min diff = -5509% changes: 136 regressions, 99 improvements, 2 unchanged ```
|
Fixed the linter failure. TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a adds a python script that pipes git diffs to compare
certain metrics sum diff. Generated by claude.
Sample usage:
Sample output:
Epic: CRDB-55052
Release note: none