scbuild: allow multiple column renames #155133
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rafiss
force-pushed
the
alter-multiple-cols
branch
from
4b51cc3 to
14e13c2
Compare
Release note: None
Release note: None
This function allows the computed column validation to be used from the declarative schema changer -- it uses a lookup function to access columns rather than referring to the table descriptor directly. Release note: None
This validates the computed column by referencing the builder state rather than the table descriptor. The table descriptor would not reflect the schema changes that are being staged by the declarative schema changer. Release note: None
This rule was matching all non-index-backed constraints, but it only needs to apply to UNIQUE WITHOUT INDEX constraints. Release note: None
This includes new dependency rules so that we fully remove the old name before allowing a new column to take on that name, and another one to make sure that a name is available before we create a computed column expression that uses that name. Release note: None
rafiss
force-pushed
the
alter-multiple-cols
branch
from
14e13c2 to
5aafad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
: <short description - lowercase, no final period>
<what was there before: Previously, ...>
<why it needed to change: This was inadequate because ...>
<what you did about it: To address this, this patch ...>