Skip to content

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jul 30, 2025

Description

This PR has the following new updates:

  • Added a new page for public datasets
  • Added a new page for dataset detail
  • Added a new dataset create page
  • Update the main menu to have Benchmarks and Datasets only
  • Updated the account menu and shifted users related material (resources, queues) to this menu
  • Added tests for datasets lists page, dataset detail, and dataset download
  • Added create and upload buttons to public benchmarks page
  • Some style updates
  • Backend functionality added for public datasets, dataset detail and datasetdownload
  • New data model fileds added (is_verified, downloads, license)

Screenshots

Public datasets page
list

Dataset detail page
detail

Dataset create page
create

Main menu
Screenshot 2025-07-31 at 1 32 32 AM

Account menu
menu

Public competitions page
create-upload

Issues this PR resolves

A checklist for hand testing

  • Comprehensive testing of this feature should be done

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah changed the title Datasets updates Datasets PR#1 - New datasets public page and related updates Aug 4, 2025
@Didayolo Didayolo self-assigned this Sep 12, 2025
@Didayolo
Copy link
Member

Didayolo commented Sep 25, 2025

Error while trying to start the service:

[...]
codabench-django-1          | ModuleNotFoundError: No module named 'drf_yasg'

Going to rebase the branch to see if it helps. Many packages were updated since the creation of the PR.

--> rebasing did solve the problem

@Didayolo
Copy link
Member

Didayolo commented Sep 25, 2025

Looks good. Some comments:

1. Required fields

We need red stars (*) for required fields:

Capture d’écran 2025-09-25 à 17 33 36

Example from task upload:

Capture d’écran 2025-09-25 à 17 33 26

2. Public / private dataset

We should have a "Make public" boolean field on the dataset creation form.

Otherwise, you upload a dataset thiking it'll be available on the datasets page, but you actually need to go to resources and make it public.

3. May need to update documentation

Note: we may need to upload the documentation and tutorials after this PR, because for instance the Resources interface moved to a new menu.

@ihsaan-ullah
Copy link
Collaborator Author

  1. Red stars (*) added for required fields
  2. Make public checkbox added
Screenshot 2025-09-29 at 4 37 17 PM

@ihsaan-ullah
Copy link
Collaborator Author

Next I am going to add some tests for datasets creation. I will take care of the documentation in next PR because I plan to add more changes to the interface so it is better to do it once.

Putting this PR in in progress for now till I add some tests

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Sep 30, 2025

NOTE 1

Please check the new test method test_cannot_create_dataset_with_missing_fields. There are 2 fields in the API that when missing are acceptable. I don't know yet if this is on purpose or by mistake. The fields are name and file_name.

I reported this problem here: #2016

NOTE 2

This is not a problem introduced in this PR so I suggest we discuss and check it and if needed resolve it in another PR.

Now this PR is ready to be merged. The documentation and the missing validation for the two fields in datasets create api will be handled in separate PRs.

@Didayolo Didayolo merged commit 27bc410 into develop Sep 30, 2025
1 check passed
@Didayolo Didayolo deleted the datasets branch September 30, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants