Skip to content

Conversation

ObadaS
Copy link
Collaborator

@ObadaS ObadaS commented Aug 8, 2025

A brief description of the purpose of the changes contained in this PR.

Changed domain name setting to not show example.com but the actual domain name defined in the .env.
Now, the correct domain name will be shown in the Django logs as well as in emails sent.

Issues this PR resolves

#1917 (partial)

A checklist for hand testing

  • Create an account
  • Check the Django container logs link that is generated for the newly created account

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Aug 11, 2025

How is the domain name wrong in the emails? It depends on the setting? For instance, the production server does produce activation emails with codabench.org links.

@ObadaS
Copy link
Collaborator Author

ObadaS commented Aug 11, 2025

It didn't work on another instance I made, it still produced example.com links even when configured with a correct DNS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants