Skip to content

Add default case in sortArguments #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
+11 −0
Open

Add default case in sortArguments #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d727ad
Add default case in sortArguments
mndominguez Oct 3, 2018
a4a862f
Add test for default argument sorter test
mndominguez Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/app/util/sortArguments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ const sortArguments = (reqArguments) => {
costs.push('paid');
break;
}

default: {
break;
}
}
});
let returnArgs = {};
Expand Down
7 changes: 7 additions & 0 deletions test/incomingParser.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ describe('parsePayload()', function () {

expect(res.actionArguments).to.eql({ 'language': ['python'] });
});

it('should return nothing', async function () {
req.body.text = 'cats are awesome';
const res = await parsePayload(req);

expect(res.actionArguments).to.be.empty;
});
});

describe('when invoked with level as arguments', function () {
Expand Down