Fix more issues with Maybes inside tuple encodings #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kallevmercury
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Nice, I tested against the issue in #51 and this PR seems to resolve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51.
After b02479d, it turned out there were still issues because a single
Maybe ain a tuple encoding was handled differently from one with two or more fields. To address this, we have to make the actual tuple instances themselves understand thegetTypeScriptOptionalstuff.This PR
test/MaybeTyples.hsTestBoilerplate.hs.CC @kallevmercury