feat: add WidgetCheckBoxes #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmileRolley
reviewed
Sep 20, 2024
| size="small" | ||
| priority="secondary" | ||
| > | ||
| Supprimer |
There was a problem hiding this comment.
question: est-ce que l'on a envie de laisser la possibilité de customiser le label des buttons avec un ui:removeLabel ?
| ) | ||
|
|
||
| const tabContent = | ||
| (items.length && ( |
There was a problem hiding this comment.
nitpick: j'avoue que je suis plutôt pour utiliser systématiquement l'opérateur ternaire pour éviter des petits bugs d'affichages non désirés (items.length ? (...) : null).
| parseInt(selectedTabId.replace(/^tab(\d+)$/, '$1')), | ||
| ) | ||
|
|
||
| const tabContent = |
There was a problem hiding this comment.
Suggested change
| const tabContent = | |
| const removeTabContent = |
| uiSchema !== undefined ? uiSchema['ui:help'] : undefined | ||
| } | ||
| > | ||
| {option.label + (required ? '*' : '')} |
There was a problem hiding this comment.
question: est-ce que la gestion des champs requis ne devrait pas être directement gérée au dans le composant <LabelWithHelp> (ou un autre composant <Label>) ?
Co-authored-by: Emile Rolley ⏚ <[email protected]> Signed-off-by: Julien Bouquillon <[email protected]>
Co-authored-by: Emile Rolley ⏚ <[email protected]> Signed-off-by: Julien Bouquillon <[email protected]>
Co-authored-by: Emile Rolley ⏚ <[email protected]> Signed-off-by: Julien Bouquillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some fixes