-
Notifications
You must be signed in to change notification settings - Fork 185
Tika 3.1, Pac4j 6.1.2, Nimbus 11.24, Bouncy Castle 1.80, POI 5.3 Upgrades #6913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.29.x
Are you sure you want to change the base?
Conversation
build now |
pom.xml
Outdated
@@ -530,7 +523,7 @@ | |||
<groupId>org.apache.james</groupId> | |||
<artifactId>apache-mime4j-dom</artifactId> | |||
</exclusion> | |||
</exclusions> | |||
</exclusions>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the commented-out code remaining for a reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, just forgot to remove it
<bundle>mvn:org.apache.tika/tika-core/${tika.version}</bundle> | ||
<bundle>mvn:org.apache.tika/tika-bundle-standard/${tika.version}</bundle> | ||
<bundle>wrap:mvn:org.apache.tika/tika-bundle-standard/${tika.version}$overwrite=merge&Import-Package=!org.junit,!org.junit.*,!junit.*,org.github.javaparser.resolution.*;resolution:=optional,org.apache.tika.*,org.slf4j,org.slf4j.event,org.slf4j.helpers,*;resolution:=optional</bundle> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is some serious Kung Fu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @pklinef for that 😄
build now |
Internal build has been started, your results will be available at build completion. |
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
What does this PR do?
Upgrades Tika to version 3.1.0
Upgrades Pac4j to version 6.1.2
Upgrades Nimbus to version 11.24
Upgrades Bouncy Castle to version 1.80
Upgrades Apache POI to version 5.3.0
Upgrades PDFBox to version 3.0.5
Who is reviewing it?
@glenhein
@pklinef
@jlcsmith
Select relevant component teams:
@codice/data
@codice/security
Ask 2 committers to review/merge the PR and tag them here.
@ahoffer
@clockard
How should this be tested?
Any background context you want to provide?
What are the relevant tickets?
Fixes: #____
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: