Skip to content

Conversation

derekwilhelm
Copy link
Contributor

What does this PR do?

Upgrades Tika to version 3.1.0
Upgrades Pac4j to version 6.1.2
Upgrades Nimbus to version 11.24
Upgrades Bouncy Castle to version 1.80
Upgrades Apache POI to version 5.3.0
Upgrades PDFBox to version 3.0.5

Who is reviewing it?

@glenhein
@pklinef
@jlcsmith

Select relevant component teams:

@codice/data
@codice/security

Ask 2 committers to review/merge the PR and tag them here.

@ahoffer
@clockard

How should this be tested?

  1. Full build with itests
  2. Install DDF and install the standard profile
  3. Configure OIDC authorization (e.g. with Keycloak)
  4. Update web-context-policy-config.properties to use OIDC (restart DDF after change)
  5. Invoke endpoints using OIDC auth with a bearer token obtained from Keycloak and verify the request is authorized as expected
  6. Ingest a variety of data (images, word documents, pdf, etc)
  7. Verify ingest is successful and metacards are populated as expected

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@derekwilhelm
Copy link
Contributor Author

build now

pom.xml Outdated
@@ -530,7 +523,7 @@
<groupId>org.apache.james</groupId>
<artifactId>apache-mime4j-dom</artifactId>
</exclusion>
</exclusions>
</exclusions>-->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the commented-out code remaining for a reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, just forgot to remove it

<bundle>mvn:org.apache.tika/tika-core/${tika.version}</bundle>
<bundle>mvn:org.apache.tika/tika-bundle-standard/${tika.version}</bundle>
<bundle>wrap:mvn:org.apache.tika/tika-bundle-standard/${tika.version}$overwrite=merge&amp;Import-Package=!org.junit,!org.junit.*,!junit.*,org.github.javaparser.resolution.*;resolution:=optional,org.apache.tika.*,org.slf4j,org.slf4j.event,org.slf4j.helpers,*;resolution:=optional</bundle>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is some serious Kung Fu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @pklinef for that 😄

@jlcsmith
Copy link
Member

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@clockard
Copy link
Contributor

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants