Add artisan test, Laravel 9 compat for Collection::dot() #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbboehr
changed the title
nerg4l
reviewed
May 20, 2025
nerg4l
reviewed
May 20, 2025
| ->dot() | ||
| ->keys() | ||
|
|
||
| $data = Collection::make($this->translator->get('*')); |
There was a problem hiding this comment.
Can you let me know what this part does?
There was a problem hiding this comment.
Yeah. $this->translator->get('*') loads the global (non-namespaced) translations in lang/{$baseLocale}.json.
I wonder if it might be better to use the found translations via scanning to build a list of groups/namespaces to load, that would support non-standard loaders.
There was a problem hiding this comment.
Isn't the point of the lang/{lang}.json, that the key is already in the base language?
There was a problem hiding this comment.
Yeah, I don't think there's anything technically preventing you from using a json file for the base locale, but it doesn't seem like it is very common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
lang/*.jsoninfindInArraylang/*.jsonexists infindInArrayArr::dot()instead ofCollection::dot()for Laravel 9 compatibilityLet me know if that all makes sense, I will test it a bit more on my codebase soon hopefully.
The commits should make sense individually, so could use the macro instead if that's preferable.
Closes #5