Narrow the return type of a few implicits #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up when upgrading our code base from an older vesion of mainargs, where we relied on chaining TokenReaders for Map and Seq. The implicit conversions require `TokensReader.Simple` as argument, but return the superclass `TokensReader`, which makes chaining impossible. Since the implementation is actually using the narrow type, we just expose it in the implicit def signature to make chaining work again.
|
I think the binary incompatibility is "by design", what can we do for this kind of changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up when upgrading our code base from an older vesion of mainargs, where we relied on chaining TokenReaders for Map and Seq. The implicit conversions require
TokensReader.Simpleas argument, but return the superclassTokensReader, which makes chaining impossible. Since the implementation is actually using the narrow type, we just expose it in the implicit def signature to make chaining work again.