-
-
Notifications
You must be signed in to change notification settings - Fork 414
Android: Add proguard-common.txt #5809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2df8aeb
draft
souvlakias 7c25fc1
add `proguard-common.txt`
souvlakias 9b840be
Eliminate need for extra dependencies and mapping r8 errors to warnin…
vaslabs 2e23026
Cleanup unnecessary deps
vaslabs ab6d6ec
Unnecessary dep
vaslabs 5c514f1
Merge branch 'main' into android-r8-no-warnings
vaslabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| #junit transitive dependency, referencing javax.lang | ||
| -dontwarn com.google.errorprone.annotations.** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # https://android.googlesource.com/platform/tools/base/+/refs/heads/studio-master-dev/build-system/gradle-core/src/main/resources/com/android/build/gradle/proguard-common.txt | ||
| -dontusemixedcaseclassnames | ||
| -dontskipnonpubliclibraryclasses | ||
| -verbose | ||
|
|
||
| # Preserve some attributes that may be required for reflection. | ||
| -keepattributes *Annotation*,Signature,InnerClasses,EnclosingMethod | ||
|
|
||
| -keep public class com.google.vending.licensing.ILicensingService | ||
| -keep public class com.android.vending.licensing.ILicensingService | ||
| -keep public class com.google.android.vending.licensing.ILicensingService | ||
| -dontnote com.android.vending.licensing.ILicensingService | ||
| -dontnote com.google.vending.licensing.ILicensingService | ||
| -dontnote com.google.android.vending.licensing.ILicensingService | ||
|
|
||
| # For native methods, see http://proguard.sourceforge.net/manual/examples.html#native | ||
| -keepclasseswithmembernames,includedescriptorclasses class * { | ||
| native <methods>; | ||
| } | ||
|
|
||
| # Keep setters in Views so that animations can still work. | ||
| -keepclassmembers public class * extends android.view.View { | ||
| void set*(***); | ||
| *** get*(); | ||
| } | ||
|
|
||
| # We want to keep methods in Activity that could be used in the XML attribute onClick. | ||
| -keepclassmembers class * extends android.app.Activity { | ||
| public void *(android.view.View); | ||
| } | ||
|
|
||
| # For enumeration classes, see http://proguard.sourceforge.net/manual/examples.html#enumerations | ||
| -keepclassmembers enum * { | ||
| public static **[] values(); | ||
| public static ** valueOf(java.lang.String); | ||
| } | ||
|
|
||
| -keepclassmembers class * implements android.os.Parcelable { | ||
| public static final ** CREATOR; | ||
| } | ||
|
|
||
| # Preserve annotated Javascript interface methods. | ||
| -keepclassmembers class * { | ||
| @android.webkit.JavascriptInterface <methods>; | ||
| } | ||
|
|
||
| # The support libraries contains references to newer platform versions. | ||
| # Don't warn about those in case this app is linking against an older | ||
| # platform version. We know about them, and they are safe. | ||
| -dontnote android.support.** | ||
| -dontnote androidx.** | ||
| -dontwarn android.support.** | ||
| -dontwarn androidx.** | ||
|
|
||
| # This class is deprecated, but remains for backward compatibility. | ||
| -dontwarn android.util.FloatMath | ||
|
|
||
| # Understand the @Keep support annotation. | ||
| -keep class android.support.annotation.Keep | ||
| -keep class androidx.annotation.Keep | ||
|
|
||
| -keep @android.support.annotation.Keep class * {*;} | ||
| -keep @androidx.annotation.Keep class * {*;} | ||
|
|
||
| -keepclasseswithmembers class * { | ||
| @android.support.annotation.Keep <methods>; | ||
| } | ||
|
|
||
| -keepclasseswithmembers class * { | ||
| @androidx.annotation.Keep <methods>; | ||
| } | ||
|
|
||
| -keepclasseswithmembers class * { | ||
| @android.support.annotation.Keep <fields>; | ||
| } | ||
|
|
||
| -keepclasseswithmembers class * { | ||
| @androidx.annotation.Keep <fields>; | ||
| } | ||
|
|
||
| -keepclasseswithmembers class * { | ||
| @android.support.annotation.Keep <init>(...); | ||
| } | ||
|
|
||
| -keepclasseswithmembers class * { | ||
| @androidx.annotation.Keep <init>(...); | ||
| } | ||
|
|
||
| # These classes are duplicated between android.jar and org.apache.http.legacy.jar. | ||
| -dontnote org.apache.http.** | ||
| -dontnote android.net.http.** | ||
|
|
||
| # These classes are duplicated between android.jar and core-lambda-stubs.jar. | ||
| -dontnote java.lang.invoke.** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to completely remove this (window extensions)